Subject: Re: [PATCH] connector: Keep the skb in cn_callback_data

From: Andrew Morton <[email-masked]>
Date: Sun, 4 Oct 2009 14:50:57 -0700

On Tue, 29 Sep 2009 16:48:08 +0200 Philipp Reisner <[email-masked]> wrote:

> Signed-off-by: Philipp Reisner <[email-masked]>
> Acked-by: Lars Ellenberg <[email-masked]>

Please don't send unchangelogged patches.

> diff --git a/include/linux/connector.h b/include/linux/connector.h
> index 47ebf41..05a7a14 100644
> --- a/include/linux/connector.h
> +++ b/include/linux/connector.h
> @@ -134,8 +134,8 @@ struct cn_callback_id {
>  struct cn_callback_data {
>  	void (*destruct_data) (void *);
>  	void *ddata;
> -	
> -	void *callback_priv;
> +
> +	struct sk_buff *skb;
>  	void (*callback) (struct cn_msg *);
>  
>  	void *free;

This one replaces the void* private pointer with the skb but you didn't
explain to us why this was done.

Also, the patch does two things.  It _adds_ the skb pointer and it also
_removes_ the opaque void* private-data pointer for the callbacks. 
What are the implications of removing callback_priv?  Why was this done?