* [PATCH] cxgb3: No need to wake queue in xmit handler
@ 2009-10-15 5:54 Krishna Kumar
2009-10-16 5:09 ` Divy Le Ray
2009-10-18 6:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Krishna Kumar @ 2009-10-15 5:54 UTC (permalink / raw)
To: davem; +Cc: netdev, divy, Krishna Kumar
The xmit handler doesn't need to wake the queue after stopping
it temporarily (some other drivers are doing the same).
Patch on net-next-2.6, multiple netperf sessions tested.
Signed-off-by: Krishna Kumar <krkumar2@in•ibm.com>
---
drivers/net/cxgb3/sge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -ruNp org/drivers/net/cxgb3/sge.c new/drivers/net/cxgb3/sge.c
--- org/drivers/net/cxgb3/sge.c 2009-09-07 10:09:03.000000000 +0530
+++ new/drivers/net/cxgb3/sge.c 2009-09-07 10:11:11.000000000 +0530
@@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *
if (should_restart_tx(q) &&
test_and_clear_bit(TXQ_ETH, &qs->txq_stopped)) {
q->restarts++;
- netif_tx_wake_queue(txq);
+ netif_tx_start_queue(txq);
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb3: No need to wake queue in xmit handler
2009-10-15 5:54 [PATCH] cxgb3: No need to wake queue in xmit handler Krishna Kumar
@ 2009-10-16 5:09 ` Divy Le Ray
2009-10-18 6:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Divy Le Ray @ 2009-10-16 5:09 UTC (permalink / raw)
To: Krishna Kumar, davem; +Cc: netdev
On Wed, 14 Oct 2009 22:54:19 -0700, Krishna Kumar <krkumar2@in•ibm.com>
wrote:
> The xmit handler doesn't need to wake the queue after stopping
> it temporarily (some other drivers are doing the same).
>
> Patch on net-next-2.6, multiple netperf sessions tested.
>
> Signed-off-by: Krishna Kumar <krkumar2@in•ibm.com>
Acked-by: Divy Le Ray <divy@chelsio•com>
> ---
>
> drivers/net/cxgb3/sge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -ruNp org/drivers/net/cxgb3/sge.c new/drivers/net/cxgb3/sge.c
> --- org/drivers/net/cxgb3/sge.c 2009-09-07 10:09:03.000000000 +0530
> +++ new/drivers/net/cxgb3/sge.c 2009-09-07 10:11:11.000000000 +0530
> @@ -1260,7 +1260,7 @@ netdev_tx_t t3_eth_xmit(struct sk_buff *
> if (should_restart_tx(q) &&
> test_and_clear_bit(TXQ_ETH, &qs->txq_stopped)) {
> q->restarts++;
> - netif_tx_wake_queue(txq);
> + netif_tx_start_queue(txq);
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cxgb3: No need to wake queue in xmit handler
2009-10-15 5:54 [PATCH] cxgb3: No need to wake queue in xmit handler Krishna Kumar
2009-10-16 5:09 ` Divy Le Ray
@ 2009-10-18 6:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-10-18 6:57 UTC (permalink / raw)
To: krkumar2; +Cc: netdev, divy
From: Krishna Kumar <krkumar2@in•ibm.com>
Date: Thu, 15 Oct 2009 11:24:19 +0530
> The xmit handler doesn't need to wake the queue after stopping
> it temporarily (some other drivers are doing the same).
>
> Patch on net-next-2.6, multiple netperf sessions tested.
>
> Signed-off-by: Krishna Kumar <krkumar2@in•ibm.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-18 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-15 5:54 [PATCH] cxgb3: No need to wake queue in xmit handler Krishna Kumar
2009-10-16 5:09 ` Divy Le Ray
2009-10-18 6:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox