From: Ursula Braun <ursula.braun@de•ibm.com>
To: davem@davemloft•net, netdev@vger•kernel.org, linux-s390@vger•kernel.org
Cc: schwidefsky@de•ibm.com, heiko.carstens@de•ibm.com,
Klaus-Dieter Wacker <kdwacker@de•ibm.com>,
Ursula Braun <ursula.braun@de•ibm.com>
Subject: [patch 3/5] [PATCH] lcs: ODEBUG: object is on stack, but not annotated.
Date: Thu, 15 Oct 2009 10:54:57 +0200 [thread overview]
Message-ID: <20091015090749.766278000@linux.vnet.ibm.com> (raw)
In-Reply-To: 20091015085454.124154000@linux.vnet.ibm.com
[-- Attachment #1: 610-lcs-odebug.diff --]
[-- Type: text/plain, Size: 993 bytes --]
From: Klaus-Dieter Wacker <kdwacker@de•ibm.com>
Timer_list structure in lcs_send_lancmd() is allocated on stack.
Initialization with init_timer() leads to above ODEBUG message.
Instead use init_timer_on_stack() which prevents above msg.
Signed-off-by: Klaus-Dieter Wacker <kdwacker@de•ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de•ibm.com>
---
drivers/s390/net/lcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urpN linux-2.6/drivers/s390/net/lcs.c linux-2.6-patched/drivers/s390/net/lcs.c
--- linux-2.6/drivers/s390/net/lcs.c 2009-10-15 10:19:32.000000000 +0200
+++ linux-2.6-patched/drivers/s390/net/lcs.c 2009-10-15 10:19:51.000000000 +0200
@@ -889,7 +889,7 @@ lcs_send_lancmd(struct lcs_card *card, s
rc = lcs_ready_buffer(&card->write, buffer);
if (rc)
return rc;
- init_timer(&timer);
+ init_timer_on_stack(&timer);
timer.function = lcs_lancmd_timeout;
timer.data = (unsigned long) reply;
timer.expires = jiffies + HZ*card->lancmd_timeout;
next prev parent reply other threads:[~2009-10-15 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 8:54 [patch 0/5] s390: networking patches for linux-next Ursula Braun
2009-10-15 8:54 ` [patch 1/5] [PATCH] af_iucv: use sk functions to modify sk->sk_ack_backlog Ursula Braun
2009-10-15 8:54 ` [patch 2/5] [PATCH] af_iucv: remove duplicate sock_set_flag Ursula Braun
2009-10-15 8:54 ` Ursula Braun [this message]
2009-10-15 8:54 ` [patch 4/5] [PATCH] lcs: Recognize return codes of ccw_device_set_online() Ursula Braun
2009-10-15 8:54 ` [patch 5/5] [PATCH] ctcm rollback in case of errors Ursula Braun
2009-10-18 6:57 ` [patch 0/5] s390: networking patches for linux-next David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015090749.766278000@linux.vnet.ibm.com \
--to=ursula.braun@de$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=kdwacker@de$(echo .)ibm.com \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=schwidefsky@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox