Subject: Re: [PATCH] sky2: set carrier off in probe

From: Stephen Hemminger <[email-masked]>
Date: Fri, 30 Oct 2009 08:34:52 -0700

Why not fix the problem in a generic way?

---
Subject: ethtool: link is only up if device is running

Signed-off-by: Stephen Hemminger <[email-masked]>

--- a/net/core/ethtool.c	2009-10-30 08:32:52.584728610 -0700
+++ b/net/core/ethtool.c	2009-10-30 08:33:31.806667877 -0700
@@ -27,7 +27,7 @@
 
 u32 ethtool_op_get_link(struct net_device *dev)
 {
-	return netif_carrier_ok(dev) ? 1 : 0;
+	return netif_running(dev) && netif_carrier_ok(dev);
 }
 
 u32 ethtool_op_get_rx_csum(struct net_device *dev)