Subject: Re: [PATCH 43/75] spider-net: declare MODULE_FIRMWARE

From: Jens Osterkamp <[email-masked]>
Date: Mon, 9 Nov 2009 12:58:13 +0100

On Saturday 07 November 2009, Ben Hutchings wrote:
> Signed-off-by: Ben Hutchings <[email-masked]>
> ---
>  drivers/net/spider_net.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
> index 90e663f..782910c 100644
> --- a/drivers/net/spider_net.c
> +++ b/drivers/net/spider_net.c
> @@ -57,6 +57,7 @@ MODULE_AUTHOR("Utz Bacher <[email-masked]> and
> Jens Osterkamp " \ MODULE_DESCRIPTION("Spider Southbridge Gigabit Ethernet
> driver"); MODULE_LICENSE("GPL");
>  MODULE_VERSION(VERSION);
> +MODULE_FIRMWARE(SPIDER_NET_FIRMWARE_NAME);
>
>  static int rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_DEFAULT;
>  static int tx_descriptors = SPIDER_NET_TX_DESCRIPTORS_DEFAULT;

In spider_net, the filesystem is checked for a valid firmware first, if it 
does not exist, the firmware is taken from the device tree (which is the 
default case).

Do you expect this behaviour to cause problems together with MODULE_FIRMWARE ?

-- 
Best regards, 

Jens Osterkamp
--------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294