From: Stephen Hemminger <shemminger@vyatta•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next-2.6] ipv4: speedup inet_dump_ifaddr()
Date: Thu, 12 Nov 2009 09:12:21 -0800 [thread overview]
Message-ID: <20091112091221.3d523253@nehalam> (raw)
In-Reply-To: <4AFC1798.1060501@gmail.com>
On Thu, 12 Nov 2009 15:11:36 +0100
Eric Dumazet <eric.dumazet@gmail•com> wrote:
> When handling large number of netdevices, inet_dump_ifaddr()
> is very slow because it has O(N^2) complexity.
>
> Instead of scanning one single list, we can use the NETDEV_HASHENTRIES
> sub lists of the dev_index hash table, and RCU lookups.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail•com>
You might be able to make RCU critical section smaller by moving
it into loop.
Acked-by: Stephen Hemminger <shemminger@vyatta•com>
next prev parent reply other threads:[~2009-11-12 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 14:11 [PATCH net-next-2.6] ipv4: speedup inet_dump_ifaddr() Eric Dumazet
2009-11-12 17:12 ` Stephen Hemminger [this message]
2009-11-12 17:44 ` Eric Dumazet
2009-11-12 19:12 ` Stephen Hemminger
2009-11-12 19:14 ` Eric Dumazet
2009-11-14 4:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091112091221.3d523253@nehalam \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox