Subject: Re: Subject: [PATCH 5/6] bna: Brocade 10Gb Ethernet device driver

From: Stephen Hemminger <[email-masked]>
Date: Thu, 12 Nov 2009 21:07:51 -0800

On Thu, 12 Nov 2009 19:46:52 -0800
Rasesh Mody <[email-masked]> wrote:

> +
> +#define wwn_t u64
> +#define lun_t u64

No need for obfuscation, at least use a typedef.

> +
> +#define WWN_NULL	(0)

Why is NULL not good enuf

> +#define FC_SYMNAME_MAX	256	/*  max name server symbolic name size */
> +#define FC_ALPA_MAX	128
> +
> +#pragma pack(1)
> +
> +#define MAC_ADDRLEN	(6)
> +struct mac { u8 mac[MAC_ADDRLEN]; };

Cant you use ETH_ALEN instead?

--