Subject: Re: [PATCH] Update embedded copy of ethtool.h from kernel 2.6.30

From: Jesper Nilsson <[email-masked]>
Date: Tue, 1 Dec 2009 16:42:46 +0100

On Tue, Dec 01, 2009 at 04:21:18PM +0100, Ben Hutchings wrote:
> On Tue, 2009-12-01 at 16:17 +0100, Jesper Nilsson wrote:
> > Commit 0c09c1a49cc7b819b33566a49d9901f7cfdd6889 in the Linux kernel
> > added a new field mdio_support inside the struct ethtool_cmd,
> > changing the struct size for architectures that does not pad structs.
> > (for example the CRIS architecture)
> 
> CRIS has no alignment requirements?!  Wow.

Yep, we don't even have the choice of adding padding inside structs. :-(

>  Sorry for changing the
> structure, then.

We're used to tripping over this kind of thing. :-)

> > This size mismatch lead to the ethtool_cmd struct being written
> > as 44 bytes in the kernel, but only 43 bytes allocated on stack,
> > overwriting one byte in the stack frame.
> > 
> > Update the ethtool copy of the definition to match the 2.6.30 kernel.
> [...]
> 
> This has already been done.

Ah? Could someone point me to the correct git-tree for ethtool then?
I've been using http://www.kernel.org/pub/scm/network/ethtool/ethtool.git
which still has this problem...

> Ben.

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- [email-masked]