Subject: [PATCH] mv643xx_eth: check for valid hw address (resubmit)

From: "Denis Kirjanov <[email-masked]" <[email-masked]>
Date: Sun, 6 Dec 2009 13:36:33 +0300

On Fri, Dec 04, 2009 at 13:30 -0800, David Miller wrote:
> From: "Denis Kirjanov <[email-masked]" <[email-masked]>
> Date: Fri, 4 Dec 2009 14:51:38 +0300
> 
> > Check for valid hw address.
> > 
> > Signed-off-by: Denis Kirjanov <[email-masked]>
> 
> Assuming we don't accept your other patch this needs
> to return -EINVAL.
(resubmitted due the fix in the return value)

Check for valid hw address.

Signed-off-by: Denis Kirjanov <[email-masked]>
---

 drivers/net/mv643xx_eth.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 796a493..1405a17 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -1827,6 +1827,9 @@ static int mv643xx_eth_set_mac_address(struct net_device *dev, void *addr)
 {
 	struct sockaddr *sa = addr;
 
+	if (!is_valid_ether_addr(sa->sa_data))
+		return -EINVAL;
+
 	memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
 
 	netif_addr_lock_bh(dev);