From: Greg KH <gregkh@suse•de>
To: Emese Revfy <re.emese@gmail•com>
Cc: lenb@kernel•org, astarikovskiy@suse•de, mchehab@infradead•org,
linville@tuxdriver•com, miklos@szeredi•hu, davem@davemloft•net,
rostedt@goodmis•org, fweisbec@gmail•com, mingo@redhat•com,
avi@redhat•com, mtosatti@redhat•com,
torvalds@linux-foundation•org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 11/31] Constify struct file_operations for 2.6.32 v1
Date: Mon, 7 Dec 2009 07:11:56 -0800 [thread overview]
Message-ID: <20091207151156.GA27574@suse.de> (raw)
In-Reply-To: <4B1C500E.5040406@gmail.com>
On Mon, Dec 07, 2009 at 01:45:02AM +0100, Emese Revfy wrote:
> Greg KH wrote:
> > On Sun, Dec 06, 2009 at 02:47:44AM +0100, Emese Revfy wrote:
> >> Greg KH wrote:
> >>> On Sat, Dec 05, 2009 at 03:50:23AM +0100, Emese Revfy wrote:
> >>>> Greg KH wrote:
> >>>>> On Sat, Dec 05, 2009 at 01:02:59AM +0100, Emese Revfy wrote:
> >>>>>> -static struct file_operations ptmx_fops;
> >>>>>> +static const struct file_operations ptmx_fops = {
> >>>>>> + .llseek = no_llseek,
> >>>>>> + .read = tty_read,
> >>>>>> + .write = tty_write,
> >>>>>> + .poll = tty_poll,
> >>>>>> + .unlocked_ioctl = tty_ioctl,
> >>>>>> + .compat_ioctl = tty_compat_ioctl,
> >>>>>> + .open = ptmx_open,
> >>>>>> + .release = tty_release,
> >>>>>> + .fasync = tty_fasync,
> >>>>>> +};
> >>>>> You just made these functions all global, for no real good reason. Why
> >>>>> did you do this?
> >>>> I think this is the only way to make ptmx_fops const, provided we want to.
> >>> Why do we want to?
> >> Because I saw that checkpatch.pl itself tries to ensure the same I went
> >> through the whole tree looking for non-const file_operations structures
> >> and tried to make them const as best as I could. If you think making
> >> ptmx_fops const is not worth the effort I will remove it from the patch.
> >
> > Based on the patch, I would think it is not worth it.
> >
> > thanks,
> >
> > greg k-h
> >
> Ok, I removed the affected hunks.
>
> From: Emese Revfy <re.emese@gmail•com>
>
> Constify struct file_operations with some exceptions.
Now please break this patch (and your others) out into "one subsystem at
a time" type thing so it will have a chance at being applied.
thanks,
greg k-h
next prev parent reply other threads:[~2009-12-07 15:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B198670.2000406@gmail.com>
[not found] ` <4B198AE3.2040003@gmail.com>
2009-12-04 22:40 ` [PATCH 08/31] Constify struct e1000_phy_operations for 2.6.32 v1 Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B198FA1.7090807@gmail.com>
2009-12-04 23:02 ` [PATCH 22/31] Constify struct neigh_ops " Emese Revfy
2009-12-04 23:19 ` David Miller
2009-12-05 0:02 ` Emese Revfy
[not found] ` <4B198DA7.1080809@gmail.com>
2009-12-04 23:05 ` [PATCH 15/31] Constify struct iwl_ops " Emese Revfy
2009-12-05 0:02 ` Emese Revfy
[not found] ` <4B198A7E.4080407@gmail.com>
2009-12-04 22:40 ` [PATCH 07/31] Constify struct e1000_nvm_operations " Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B198A33.7080705@gmail.com>
2009-12-04 22:39 ` [PATCH 06/31] Constify struct e1000_mac_operations " Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B19A337.6060808@gmail.com>
2009-12-05 0:40 ` Stephen Rothwell
2009-12-05 1:18 ` Emese Revfy
2009-12-05 1:21 ` Jeff Kirsher
[not found] ` <4B1991E2.5010903@gmail.com>
2009-12-04 23:00 ` [PATCH 29/31] Constify struct sysfs_ops " Emese Revfy
2009-12-05 0:03 ` Emese Revfy
2009-12-05 21:15 ` Jens Axboe
2009-12-06 8:58 ` Pekka Enberg
2009-12-07 9:53 ` Hans J. Koch
[not found] ` <4B198C43.50205@gmail.com>
[not found] ` <4B19A333.5080103@gmail.com>
2009-12-05 0:09 ` [PATCH 11/31] Constify struct file_operations " Greg KH
2009-12-05 2:50 ` Emese Revfy
2009-12-05 4:15 ` Greg KH
2009-12-06 1:47 ` Emese Revfy
2009-12-06 17:25 ` Greg KH
2009-12-07 0:45 ` Emese Revfy
2009-12-07 15:11 ` Greg KH [this message]
2009-12-07 17:35 ` Emese Revfy
2009-12-07 17:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207151156.GA27574@suse.de \
--to=gregkh@suse$(echo .)de \
--cc=astarikovskiy@suse$(echo .)de \
--cc=avi@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fweisbec@gmail$(echo .)com \
--cc=lenb@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=mchehab@infradead$(echo .)org \
--cc=miklos@szeredi$(echo .)hu \
--cc=mingo@redhat$(echo .)com \
--cc=mtosatti@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=re.emese@gmail$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox