From: Grant Grundler <grundler@parisc-linux•org>
To: Dan Carpenter <error27@gmail•com>
Cc: Grant Grundler <grundler@parisc-linux•org>,
Kyle McMartin <kyle@mcmartin•ca>,
netdev@vger•kernel.org
Subject: Re: potential overflow in de4x5.c
Date: Mon, 4 Jan 2010 00:28:44 -0700 [thread overview]
Message-ID: <20100104072844.GB518@lackof.org> (raw)
In-Reply-To: <20100103101356.GA13023@bicker>
On Sun, Jan 03, 2010 at 12:13:56PM +0200, Dan Carpenter wrote:
> Hi I found this using smatch (http://repo.or.cz/w/smatch.git).
>
> drivers/net/tulip/de4x5.c
> 4772 lp->active = *p++;
> 4773 if (MOTO_SROM_BUG) lp->active = 0;
> 4774 lp->phy[lp->active].gep = (*p ? p : NULL); p += (2 * (*p) + 1);
>
> lp->phy is an array of size 8.
>
> MOTO_SROM_BUG is defined like this.
>
> #define MOTO_SROM_BUG (lp->active == 8 && (get_unaligned_le32(dev->dev_addr) & 0x00ffffff) == 0x3e0008)
>
> If lp->active == 8 then we have a buffer overflow.
Dan,
When does the overflow actually occur?
That code is reseting the value to work around a specific SROM bug:
http://lists.ozlabs.org/pipermail/linuxppc-dev/1999-March/001421.html
If you want to make the "input validation" more robust, that would be fine with me.
But smatch hasn't convinced me there is a bug here.
thanks,
grant
>
> regards,
> dan carpenter
next prev parent reply other threads:[~2010-01-04 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-03 10:13 potential overflow in de4x5.c Dan Carpenter
2010-01-04 7:28 ` Grant Grundler [this message]
2010-01-04 7:35 ` Grant Grundler
2010-01-07 15:40 ` Dan Carpenter
2010-01-13 4:31 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104072844.GB518@lackof.org \
--to=grundler@parisc-linux$(echo .)org \
--cc=error27@gmail$(echo .)com \
--cc=kyle@mcmartin$(echo .)ca \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox