Subject: Re: [PATCH 1/1] Constify struct sysfs_ops for v2.6.33-rc4

From: Greg KH <[email-masked]>
Date: Sun, 17 Jan 2010 17:35:21 -0800

On Sun, Jan 17, 2010 at 09:15:49PM +0100, Emese Revfy wrote:
> Al Viro wrote:
> > On Sun, Jan 17, 2010 at 05:20:38PM +0100, Emese Revfy wrote:
> > 
> >> Signed-off-by: Emese Revfy <[email-masked]>
> >> Acked-by: David Teigland <[email-masked]>
> >> Acked-by: Matt Domsch <[email-masked]>
> >> Acked-by: Maciej Sosnowski <[email-masked]>
> >> Acked-by: Hans J. Koch <[email-masked]>
> >> Acked-by: Pekka Enberg <[email-masked]>
> >> Acked-by: Jens Axboe <[email-masked]>
> >> Acked-by: Stephen Hemminger <[email-masked]>
> > 
> > NACKed-by: Al Viro <[email-masked]>
> > 
> > Same reason.
> > 
> >> -        ssize_t (*show)(struct kobject *, struct attribute *, char *);
> >> -        ssize_t (*store)(struct kobject *, struct attribute *, const char *);
> >> +        ssize_t (* const show)(struct kobject *, struct attribute *, char *);
> >> +        ssize_t (* const store)(struct kobject *, struct attribute *, const char *);
> > 
> 
> Ok, I removed the field constification, here's the updated patch:

Please resend with proper changelog and other information so that it
could be applied.

thanks,

greg k-h