Subject: Re: [PATCH 1/1 V4] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver

From: Stephen Hemminger <[email-masked]>
Date: Mon, 25 Jan 2010 08:31:31 -0800

On Mon, 25 Jan 2010 12:01:12 +0100
Kristoffer Glembo <[email-masked]> wrote:

> +/* Accept MAC address of the form macaddr=0x08,0x00,0x20,0x30,0x40,0x50 */
> +static int macaddr[6];
> +module_param_array(macaddr, int, NULL, 0);
> +MODULE_PARM_DESC(macaddr, "GRETH Ethernet MAC address");

Don't you want an array of uchar here not int?

--