Subject: Re: [PATCH 2/3] sky2: Allocate initial skbs in sky2_alloc_buffers

From: Stephen Hemminger <[email-masked]>
Date: Wed, 27 Jan 2010 09:00:16 -0800

On Thu, 28 Jan 2010 00:05:44 +0900
Mike McCormack <[email-masked]> wrote:

> Allocating everything in one place means there's a single point
> of failure in sky2_up, and sky2_rx_start can no longer fail.
> 
> This also fixes a memory leak in the case that sky2_rx_start
> fails in the middle of allocating skbs, since any allocated
> skbs will not be free'd in sky2_up's failure path.

I may incorporate the cleanup, but there is no leak.
if rx_start fails, it already called rx_clean.