From: "M. Warner Losh" <imp-uzTCJ5RojNnQT0dZR+AlfA@public•gmane.org>
To: scottwood-KZfg59tc24xl57MIdRCFDg@public•gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org,
afleming-KZfg59tc24xl57MIdRCFDg@public•gmane.org
Subject: Re: phy address in the device tree, vs auto probing
Date: Wed, 10 Feb 2010 11:37:20 -0700 (MST) [thread overview]
Message-ID: <20100210.113720.1026572228166328165.imp@bsdimp.com> (raw)
In-Reply-To: <4B72FAB2.5000804-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
In message: <4B72FAB2.5000804-KZfg59tc24xl57MIdRCFDg@public•gmane.org>
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public•gmane.org> writes:
: Grant Likely wrote:
: >> 1. What if we just don't specific a phy address with a reg property
: >> which would specify to auto probe it and find the phy as illustrated
: >> below?
: >>
: >>
: >> Ethernet_MAC: ethernet@81000000 {
: >> #address-cells = <1>;
: >> #size-cells = <1>;
: >> phy-handle = <&phy0>;
: >> mdio {
: >> #address-cells = <1>;
: >> #size-cells = <0>;
: >> phy0: phy@7 {
: >> } ;
: >> } ;
: >>
: >> 2. Or a special value (-1 or something not 0 - 31) in the phy address
: >> that specifies to auto probe as illustrated below.
: >> phy0: phy@7 {
: >> reg = <-1>;
: >> } ;
: > I don't like abusing the reg property in this way. I wonder if a new
: > empty property would be a better way to indicate this. Maybe
: > "phy-probe-address;"? It would also be important to specify in the
: > binding that only one phy node is allowed when phy-probe-address is
: > used.
: > Also, without a known reg the 'phy@7' name is inaccurate. Drop the
: > @7.
: > Scott, Andy: any thoughts?
:
: I'm not fond of the -1. I'd prefer the explicit phy-probe-address
: property, though I don't mind too much using the absence of reg.
There are times that you'd want a list of PHY addresses to use. This
suggests a bitmask, but I don't know if they are common enough to
warrant the extra burden on the usual case...
Warner
next prev parent reply other threads:[~2010-02-10 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Acqp3tpO+gBYUakZQ7SaeBzVIkh6WA==>
[not found] ` <4dfe033d-c308-45e0-9c7e-9fc60c6cad8f@SG2EHSMHS013.ehs.local>
[not found] ` <4dfe033d-c308-45e0-9c7e-9fc60c6cad8f-RaUQJvECHivT7m58JnLnSLjjLBE8jN/0@public.gmane.org>
2010-02-10 16:43 ` phy address in the device tree, vs auto probing Grant Likely
2010-02-10 16:52 ` John Linn
2010-02-10 18:14 ` Grant Likely
[not found] ` <fa686aa41002101014s43682e3cra55854b82a40bb5f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-10 18:28 ` Scott Wood
[not found] ` <4B72FAB2.5000804-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-02-10 18:37 ` M. Warner Losh [this message]
2010-02-10 19:12 ` Grant Likely
2010-02-10 19:24 ` Mark Brown
2010-02-10 18:30 ` Mitch Bradley
[not found] ` <4B72FB38.7080909-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2010-02-10 18:35 ` Mitch Bradley
2010-02-10 18:40 ` Fleming Andy-AFLEMING
2010-02-10 19:20 ` Grant Likely
2010-02-10 19:46 ` Andy Fleming
2010-02-10 19:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210.113720.1026572228166328165.imp@bsdimp.com \
--to=imp-uztcj5rojnnqt0dzr+alfa@public$(echo .)gmane.org \
--cc=afleming-KZfg59tc24xl57MIdRCFDg@public$(echo .)gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=scottwood-KZfg59tc24xl57MIdRCFDg@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox