Subject: Re: [PATCH 2/5] sky2: Allocate initial skbs in sky2_alloc_buffers

From: Stephen Hemminger <[email-masked]>
Date: Wed, 10 Feb 2010 08:04:52 -0800

On Wed, 10 Feb 2010 23:12:01 +0900
Mike McCormack <[email-masked]> wrote:

> +		re->skb = sky2_rx_alloc(sky2);
> +		if (!re->skb)
> +			goto nomem;
> +
> +		if (sky2_rx_map_skb(hw->pdev, re, sky2->rx_data_size)) {
> +			dev_kfree_skb(re->skb);
> +			re->skb = NULL;
> +			goto nomem;
> +		}
> +	}
> +	return 0;
> +nomem:
> +	return -ENOMEM;

I like this and will put it all together with my patch set
But will get rid of silly things goto a return statement.

--