Subject: Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

From: Stephen Hemminger <[email-masked]>
Date: Wed, 10 Feb 2010 09:08:05 -0800

On Tue, 9 Feb 2010 22:29:15 -0800
Rasesh Mody <[email-masked]> wrote:

> +		BUG_ON(!(skb));

This driver seems to have lots of extra BUG_ON assertions
which implies either paranoia or still in development.

Putting in a check for NULL in places like this is not really
helpful. The check requires overhead, and will not provide any additional
help to the user. If the BUG_ON() is there the user will see
a backtrace and that cpu will be stuck ... if the BUG_ON was omitted,
and the skb was NULL, user would see a backtrace and cpu would
be stuck.

--