Subject: Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

From: Stephen Hemminger <[email-masked]>
Date: Wed, 10 Feb 2010 09:09:46 -0800

On Tue, 9 Feb 2010 22:29:15 -0800
Rasesh Mody <[email-masked]> wrote:

> +#define bnad_conf_lock()	down(&bnad->conf_sem)
> +#define bnad_conf_unlock()	up(&bnad->conf_sem)

Don't wrap locking in macros.
Don't use semaphores as locks, use mutex.

--