From: Jiri Pirko <jpirko@redhat•com>
To: kirjanov@gmail•com
Cc: davem@davemloft•net, kristoffer@gaisler•com, netdev@vger•kernel.org
Subject: Re: [PATCH] greth: some driver cleanups
Date: Fri, 19 Feb 2010 13:51:51 +0100 [thread overview]
Message-ID: <20100219125148.GA6598@psychotron.redhat.com> (raw)
In-Reply-To: <20100219120425.GD2644@psychotron.redhat.com>
<snip>
>>@@ -1031,7 +1029,7 @@ static void greth_set_multicast_list(struct net_device *dev)
>> return;
>> }
>>
>>- if (dev->mc_count == 0) {
>>+ if (!netdev_mc_count(dev)) {
also please use netdev_mc_empty() here.
next prev parent reply other threads:[~2010-02-19 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 11:14 [PATCH] greth: some driver cleanups Denis Kirjanov <kirjanov@gmail•com
2010-02-19 12:04 ` Jiri Pirko
2010-02-19 12:51 ` Jiri Pirko [this message]
2010-02-19 15:00 ` Denis Kirjanov <kirjanov@gmail•com
2010-02-19 15:25 ` Jiri Pirko
2010-02-19 21:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219125148.GA6598@psychotron.redhat.com \
--to=jpirko@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kirjanov@gmail$(echo .)com \
--cc=kristoffer@gaisler$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox