public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash•net>
To: netdev@vger•kernel.org
Cc: Patrick McHardy <kaber@trash•net>
Subject: net 01/04: rtnetlink: ignore NETDEV_PRE_UP notifier in rtnetlink_event()
Date: Fri, 26 Feb 2010 17:34:50 +0100 (MET)	[thread overview]
Message-ID: <20100226163450.11434.29192.sendpatchset@x2.localnet> (raw)
In-Reply-To: <20100226163449.11434.13013.sendpatchset@x2.localnet>

commit 140dcbaa692be4ce66e68624d438aed030184186
Author: Patrick McHardy <kaber@trash•net>
Date:   Tue Feb 23 20:56:39 2010 +0100

    net: rtnetlink: ignore NETDEV_PRE_UP notifier in rtnetlink_event()
    
    Commit 3b8bcfd (net: introduce pre-up netdev notifier) added a new
    notifier which is run before a device is set UP for use by cfg80211.
    
    The patch missed to add the new notifier to the ignore list in
    rtnetlink_event(), so we currently get an unnecessary netlink
    notification before a device is set UP.
    
    Signed-off-by: Patrick McHardy <kaber@trash•net>

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 4dd4c3c..b7c7dfd 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1432,6 +1432,7 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
 	case NETDEV_DOWN:
 		rtmsg_ifinfo(RTM_NEWLINK, dev, IFF_UP|IFF_RUNNING);
 		break;
+	case NETDEV_PRE_UP:
 	case NETDEV_POST_INIT:
 	case NETDEV_REGISTER:
 	case NETDEV_CHANGE:

  reply	other threads:[~2010-02-26 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 16:34 net: rtnetlink: support specifying device flags on device creation Patrick McHardy
2010-02-26 16:34 ` Patrick McHardy [this message]
2010-02-26 16:34 ` net 02/04: rtnetlink: handle rtnl_link netlink notifications manually Patrick McHardy
2010-02-26 16:34 ` net 03/04: dev: support deferring device flag change notifications Patrick McHardy
2010-02-26 16:34 ` net 04/04: rtnetlink: support specifying device flags on device creation Patrick McHardy
2010-02-27 10:51 ` net: " David Miller
2010-03-01 15:24   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226163450.11434.29192.sendpatchset@x2.localnet \
    --to=kaber@trash$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox