Subject: Re: [net-2.6 PATCH] af_packet: move strict addr_len check right before dev_[mc/unicast]_[add/del]

From: Jiri Pirko <[email-masked]>
Date: Wed, 3 Mar 2010 08:36:03 +0100

Wed, Mar 03, 2010 at 08:01:10AM CET, [email-masked] wrote:
>Quoting Jiri Pirko <[email-masked]>:
>
>>@@ -1734,7 +1738,7 @@ static int packet_mc_add(struct sock *sk,
>>struct packet_mreq_max *mreq)
>> 		goto done;
>>
>> 	err = -EINVAL;
>>-	if (mreq->mr_alen != dev->addr_len)
>>+	if (mreq->mr_alen > dev->addr_len)
>> 		goto done;
>>
>> 	err = -ENOBUFS;
>
>The patch looks good, but did you mean to include this change?  It's
>not described.

Sure - this is revert of the bit from my original patch. I think it's clear from
description.

Jirka

>-- 
>Regards,
>Pavel Roskin