From: Octavian Purdila <opurdila@ixiacom•com>
To: Cong Wang <amwang@redhat•com>
Cc: "Eric W. Biederman" <ebiederm@xmission•com>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
nhorman@tuxdriver•com, eric.dumazet@gmail•com
Subject: Re: [net-next PATCH v6 0/3] net: reserve ports for applications using fixed port numbers
Date: Wed, 10 Mar 2010 14:42:47 +0200 [thread overview]
Message-ID: <201003101442.47192.opurdila@ixiacom.com> (raw)
In-Reply-To: <4B976503.4050702@redhat.com>
On Wednesday 10 March 2010 11:23:15 you wrote:
> Eric W. Biederman wrote:
> > I would add the restriction that the values in the list of ranges
> > always must be increasing, and in general restrict the set of accepted
> > values as much as possible. If we don't accept it now we don't have
> > to worry about some userspace application relying on some unitended
> > side effect a few years into the future.
>
> I don't think this is good.
>
> Suppose that when I just want to add one port into the list and keep the
> original ones, I want to do this:
>
> orig=$(cat ip_local_reserved_ports)
> new_list="$orig, $new_one"
> echo "$new_list" > ip_local_reserved_ports
>
> If we add this restriction, the above could be failed if the new port
> is lower than the original ones. This will be not convenient.
>
> > I think it is a serious bug that you clear the destination bitmap
> > in the middle of parsing it. That will either open or close all
> > ports in the middle of parsing, and I can't see how that would
> > ever be a good thing.
>
> Agreed.
>
> By the way, Octavian, any new updates?
>
Sorry, didn't got time to work on this lately, but I will submit a new version
I hope end of this week to address Eric's comments.
next prev parent reply other threads:[~2010-03-10 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 1:25 [net-next PATCH v6 0/3] net: reserve ports for applications using fixed port numbers Octavian Purdila
2010-02-27 1:25 ` [net-next PATCH v6 1/3] sysctl: refactor integer handling proc code Octavian Purdila
2010-02-27 1:25 ` [net-next PATCH v6 2/3] sysctl: add proc_do_large_bitmap Octavian Purdila
2010-02-27 1:25 ` [net-next PATCH v6 3/3] net: reserve ports for applications using fixed port numbers Octavian Purdila
2010-02-27 11:32 ` [net-next PATCH v6 0/3] " David Miller
2010-03-04 8:31 ` Cong Wang
2010-03-04 19:14 ` Eric W. Biederman
2010-03-04 20:11 ` Octavian Purdila
2010-03-04 21:14 ` Eric W. Biederman
2010-03-10 9:23 ` Cong Wang
2010-03-10 12:42 ` Octavian Purdila [this message]
2010-03-01 4:15 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003101442.47192.opurdila@ixiacom.com \
--to=opurdila@ixiacom$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox