Subject: Re: [PATCH] net: ipmr/ip6mr: prevent out-of-bounds vif_table access

From: David Miller <[email-masked]>
Date: Fri, 26 Mar 2010 11:11:45 -0700 (PDT)

From: Nicolas Dichtel <[email-masked]>
Date: Fri, 26 Mar 2010 18:19:34 +0100

> yes, but I think that it is not enough, ip[6]mr_mfc_add() is only
> called via setsockopt().
> 
> When a multicast packet arrived in ip6_mr_input(), if there is no
> cache ip6mr_cache_unresolved() will be called and this function will
> add an entry with parent == 65535.
> 
> And the second problem is that when a vif is removed, no cleanup is
> made in cache entry. Hence, we can have a cache entry which points to
> an invalid vif (dev is set ot NULL).

Ok, I'll take another look at your patch, thanks for
explaining.