From: Al Viro <viro@ZenIV•linux.org.uk>
To: Fran?ois Romieu <romieu@fr•zoreil.com>
Cc: Ben Hutchings <ben@decadent•org.uk>,
David Miller <davem@davemloft•net>,
timo.teras@iki•fi, ivecera@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH] r8169: fix broken register writes
Date: Sun, 28 Mar 2010 23:19:24 +0100 [thread overview]
Message-ID: <20100328221924.GG30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100328212858.GA4220@electric-eye.fr.zoreil.com>
On Sun, Mar 28, 2010 at 11:28:58PM +0200, Fran?ois Romieu wrote:
> Ben Hutchings <ben@decadent•org.uk> :
> [...]
> > Thanks Fran?ois. Which hardware have you tested this on so far ?
>
> 10ec:8169 (rev 10) / RTL8169sb/8110sb / XID 10000000
>
> Timo's is a 10ec:8167 / RTL8169sc/8110sc / XID 18000000. He only tested
> the MAC[04] part.
FWIW, XID18000000 here (J7F4) loses MAC4 on shutdown; hadn't tested the patch
yet. 2.6.26 (on that box) and 2.6.31 (on identical mb) work, 2.6.33 doesn't.
I suspect that bisect would lead to commit cc098dc70 (i.e. the place where we
started to set address on shutdown). One more data point: ifconfig hw ether
done under 2.6.26 did restore the address. And that's the same function,
isn't it?
Another interesting bit: unlike the older kernel, grep for eth0 in .33 dmesg
eth0: RTL8169sc/8110sc at 0xf87fc000, 00:30:18:a4:65:89, XID 18000000 IRQ 18
r8169: eth0: link down
ADDRCONF(NETDEV_UP): eth0: link is not ready
r8169: eth0: link up
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
where with .26 (with the same userland) had
eth0: RTL8169sc/8110sc at 0xf87fc000, 00:30:18:a4:65:89, XID 18000000 IRQ 18
r8169: eth0: link up
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
Same for .31 on another box, modulo different address there...
next prev parent reply other threads:[~2010-03-28 22:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 10:28 r8169 mac reading/writing broken Timo Teräs
2010-03-27 11:40 ` François Romieu
2010-03-27 11:46 ` Timo Teräs
2010-03-27 12:03 ` François Romieu
2010-03-27 12:16 ` Timo Teräs
2010-03-27 12:25 ` Timo Teräs
2010-03-27 12:26 ` François Romieu
2010-03-27 12:32 ` Timo Teräs
2010-03-27 20:37 ` Timo Teräs
2010-03-27 21:11 ` François Romieu
2010-03-27 23:20 ` Ben Hutchings
2010-03-27 23:30 ` David Miller
2010-03-28 0:31 ` [PATCH] r8169: fix broken register writes François Romieu
2010-03-28 0:47 ` Ben Hutchings
2010-03-28 21:28 ` François Romieu
2010-03-28 22:19 ` Al Viro [this message]
2010-03-29 1:03 ` Al Viro
2010-03-29 2:17 ` Al Viro
2010-03-31 20:27 ` =?unknown-8bit?B?RnJhbsOnb2lz?= Romieu
2010-03-29 21:11 ` François Romieu
2010-03-28 2:38 ` David Miller
2010-03-28 22:04 ` François Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100328221924.GG30031@ZenIV.linux.org.uk \
--to=viro@zeniv$(echo .)linux.org.uk \
--cc=ben@decadent$(echo .)org.uk \
--cc=davem@davemloft$(echo .)net \
--cc=ivecera@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=timo.teras@iki$(echo .)fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox