Subject: Re: [PATCH v3 10/12] l2tp: Add L2TP ethernet pseudowire support

From: Stephen Hemminger <[email-masked]>
Date: Tue, 30 Mar 2010 09:30:09 -0700

On Tue, 30 Mar 2010 17:18:19 +0100
James Chapman <[email-masked]> wrote:

> static inline struct l2tp_eth_net *l2tp_eth_pernet(struct net *net)
> +{
> +	BUG_ON(!net);
> +
> +	return net_generic(net, l2tp_eth_net_id);
> +}

Don't test for NULL with BUG_ON. It is redundant, the null
dereference will cause the same kind of backtrace failure.

--