Subject: Re: [PATCH] MACB: Set PHY address in kernel parameters

From: Anders Darander <[email-masked]>
Date: Wed, 31 Mar 2010 10:50:25 +0200

* Patrick McHardy <[email-masked]> [100331 10:29]:
> Anders Darander wrote:
> > +	if (phy_addr >= PHY_MAX_ADDRESS)
> > +		phydev = phy_find_first(bp->mii_bus);
> > +	else
> > +		phydev = bp->mii_bus->phy_map[phy_addr];

> This looks like you need to use an unsigned to avoid negative
> indices.

Thanks for spotting this. That made me find that I'd also been inconsistent with the variable and module parameter declarations.

A new version, V2, of the patch has been sent.

Best regards,
Anders Darander