From: "Michael S. Tsirkin" <mst@redhat•com>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] virtio_net: avoid BUG_ON() with large packets when CONFIG_DEBUG_SG=y
Date: Wed, 31 Mar 2010 12:17:46 +0300 [thread overview]
Message-ID: <20100331091746.GB31085@redhat.com> (raw)
In-Reply-To: <201003301526.35720.rusty@rustcorp.com.au>
On Tue, Mar 30, 2010 at 03:26:35PM +1030, Rusty Russell wrote:
> AFAICT only weird kvm setups and lguest traverse this code path now.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp•com.au>
vhost still lacks support mergeable buffers so it uses this path.
> ---
> drivers/net/virtio_net.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -351,6 +351,9 @@ static int add_recvbuf_big(struct virtne
> char *p;
> int i, err, offset;
>
> + /* This is a waste of cycles, but satisfies CONFIG_DEBUG_SG. */
> + sg_init_table(sg, ARRAY_SIZE(sg));
> +
How about moving sg into virtnet_info? This way we could call
this only once, right?
> /* page in sg[MAX_SKB_FRAGS + 1] is list tail */
> for (i = MAX_SKB_FRAGS + 1; i > 1; --i) {
> first = get_a_page(vi, gfp);
prev parent reply other threads:[~2010-03-31 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 4:56 [PATCH] virtio_net: avoid BUG_ON() with large packets when CONFIG_DEBUG_SG=y Rusty Russell
2010-03-30 5:08 ` David Miller
2010-03-31 0:35 ` Rusty Russell
2010-03-31 5:39 ` Shirley Ma
2010-03-31 9:17 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331091746.GB31085@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox