From: Andrew Morton <akpm@linux-foundation•org>
To: "Ira W. Snyder" <iws@ovro•caltech.edu>
Cc: linux-kernel@vger•kernel.org, socketcan-core@lists•berlios.de,
netdev@vger•kernel.org, sameo@linux•intel.com
Subject: Re: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module
Date: Thu, 1 Apr 2010 13:03:59 -0700 [thread overview]
Message-ID: <20100401130359.9a9b5c7b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1269881932-3803-3-git-send-email-iws@ovro.caltech.edu>
On Mon, 29 Mar 2010 09:58:51 -0700
"Ira W. Snyder" <iws@ovro•caltech.edu> wrote:
> The Janz VMOD-ICAN3 is a MODULbus daughterboard which fits onto any
> MODULbus carrier board. It is an intelligent CAN controller with a
> microcontroller and associated firmware.
>
A neat-looking driver.
> ...
>
> + spin_lock_irqsave(&mod->lock, flags);
>
> ...
It does this rather a lot. it seems to be doing quite a lot of work
under that lock, too - quite a lot of memcpy_toio(), other stuff.
Is there potential here to disable interrupt for too long? Not
possible to use spin_lock_bh() here?
next prev parent reply other threads:[~2010-04-01 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 16:58 [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module Ira W. Snyder
[not found] ` <1269881932-3803-3-git-send-email-iws-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-30 8:14 ` Wolfgang Grandegger
2010-03-31 6:46 ` David Miller
2010-04-01 20:03 ` Andrew Morton [this message]
[not found] ` <20100401130359.9a9b5c7b.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-04-02 0:43 ` Ira W. Snyder
-- strict thread matches above, loose matches on Subject: below --
2010-03-18 16:38 Ira W. Snyder
[not found] ` <1268930324-29841-3-git-send-email-iws-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-19 9:01 ` Wolfgang Grandegger
[not found] ` <4BA33D5A.8070000-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-03-19 15:19 ` Ira W. Snyder
2010-03-19 15:45 ` Wolfgang Grandegger
2010-03-19 20:03 ` Ira W. Snyder
[not found] ` <20100319200325.GE13672-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-19 20:13 ` Wolfgang Grandegger
2010-03-19 21:52 ` Ira W. Snyder
[not found] ` <20100319215227.GF13672-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-20 7:55 ` Wolfgang Grandegger
[not found] ` <4BA47F64.8030108-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-03-22 15:53 ` Ira W. Snyder
[not found] ` <20100322155318.GA19251-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-22 19:17 ` Wolfgang Grandegger
[not found] ` <4BA7C236.9060609-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-03-22 19:23 ` Wolfgang Grandegger
[not found] ` <4BA7C3BE.8040306-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-03-22 20:12 ` Ira W. Snyder
2010-03-22 20:10 ` Ira W. Snyder
[not found] ` <20100322201039.GA19327-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-22 20:28 ` Wolfgang Grandegger
[not found] ` <4BA7D2E9.6010007-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-03-22 20:51 ` Ira W. Snyder
[not found] ` <20100322205101.GC19327-lulEs6mt1IksTUYHLfqkUA@public.gmane.org>
2010-03-22 21:24 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401130359.9a9b5c7b.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=iws@ovro$(echo .)caltech.edu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sameo@linux$(echo .)intel.com \
--cc=socketcan-core@lists$(echo .)berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox