From: Sebastien Jan <s-jan@ti•com>
To: David Miller <davem@davemloft•net>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-omap@vger•kernel.org" <linux-omap@vger•kernel.org>,
"Arce, Abraham" <x0066660@ti•com>,
"ben-linux@fluff•org" <ben-linux@fluff•org>,
"Tristram.Ha@micrel•com" <Tristram.Ha@micrel•com>
Subject: Re: [PATCH 4/4 v2] ks8851: read/write MAC address on companion eeprom through debugfs
Date: Thu, 6 May 2010 10:01:49 +0200 [thread overview]
Message-ID: <201005061001.49747.s-jan@ti.com> (raw)
In-Reply-To: <20100506.002508.241926083.davem@davemloft.net>
Hi david,
On Thursday 06 May 2010 09:25:08 David Miller wrote:
> From: Sebastien Jan <s-jan@ti•com>
> Date: Wed, 5 May 2010 20:45:55 +0200
>
> > A more elegant alternative to ethtool for updating the ks8851
> > MAC address stored on its companion eeprom.
> > Using this debugfs interface does not require any knowledge on the
> > ks8851 companion eeprom organization to update the MAC address.
> >
> > Example to write 01:23:45:67:89:AB MAC address to the companion
> > eeprom (assuming debugfs is mounted in /sys/kernel/debug):
> > $ echo "01:23:45:67:89:AB" > /sys/kernel/debug/ks8851/mac_eeprom
> >
> > Signed-off-by: Sebastien Jan <s-jan@ti•com>
>
> Elegant? This commit message is the biggest lie ever told.
>
> What makes your ethernet driver so god-damn special that it deserves
> to have a private, completely unique, and obscure interface for
> setting the permanent ethernet address of a network device?
>
> Tell me how damn elegant it is that users have to learn about this
> special, unique, and common with no other driver, interface for
> performing this task?
>
> Tell me how damn elegant it is when another driver wants to provide
> users with a way to do this too, and they (like you) come up with
> their own unique and different interface for doing this.
>
> No, this is the most inelegant patch ever conceived because it totally
> ignores the way in which we handle issues like this.
>
> There is no way in the world I'm applying this garbage patch, sorry.
>
> We have an ETHTOOL_GPERMADDR, add a new ETHTOOL_SPERMADDR operation
> and then any driver (not just your's) can portably provide this
> facility and users will have one, and only one, way of performing this
> task.
>
I agree that my commit message was probably too provocative, sorry for that.
Thank you for shedding some light on ETHTOOL_GPERMADDR and ETHTOOL_SPERMADDR.
I will look into these interfaces for a proper and generic implementation.
prev parent reply other threads:[~2010-05-06 8:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 18:45 [PATCH 0/4 v2] ks8851: support for read/write MAC address from eeprom Sebastien Jan
2010-05-05 18:45 ` [PATCH 1/4 v2] ks8851: Add caching of CCR register Sebastien Jan
2010-05-06 7:20 ` David Miller
2010-05-05 18:45 ` [PATCH 2/4 v2] ks8851: Low level functions for read/write to companion eeprom Sebastien Jan
2010-05-06 7:20 ` David Miller
2010-05-11 1:23 ` Ben Dooks
2010-05-11 5:59 ` David Miller
2010-05-11 1:16 ` Ben Dooks
2010-05-05 18:45 ` [PATCH 3/4 v2] ks8851: companion eeprom access through ethtool Sebastien Jan
2010-05-06 7:20 ` David Miller
2010-05-05 18:45 ` [PATCH 4/4 v2] ks8851: read/write MAC address on companion eeprom through debugfs Sebastien Jan
2010-05-06 7:25 ` David Miller
2010-05-06 8:01 ` Sebastien Jan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005061001.49747.s-jan@ti.com \
--to=s-jan@ti$(echo .)com \
--cc=Tristram.Ha@micrel$(echo .)com \
--cc=ben-linux@fluff$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=x0066660@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox