From: Arnd Bergmann <arnd@arndb•de>
To: Scott Feldman <scofeldm@cisco•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, chrisw@redhat•com
Subject: Re: [net-next-2.6 V5 PATCH 2/3] Add ndo_{set|get}_vf_port_profile op support for enic dynamic vnics
Date: Thu, 6 May 2010 15:47:22 +0200 [thread overview]
Message-ID: <201005061547.22400.arnd@arndb.de> (raw)
In-Reply-To: <20100506044211.29677.59331.stgit@savbu-pc100.cisco.com>
On Thursday 06 May 2010, Scott Feldman wrote:
> @@ -810,14 +819,24 @@ static void enic_reset_mcaddrs(struct enic *enic)
>
> static int enic_set_mac_addr(struct net_device *netdev, char *addr)
> {
> - if (!is_valid_ether_addr(addr))
> - return -EADDRNOTAVAIL;
> + struct enic *enic = netdev_priv(netdev);
>
> - memcpy(netdev->dev_addr, addr, netdev->addr_len);
> + if (enic_is_dynamic(enic)) {
> + random_ether_addr(netdev->dev_addr);
> + } else {
> + if (!is_valid_ether_addr(addr))
> + return -EADDRNOTAVAIL;
> + memcpy(netdev->dev_addr, addr, netdev->addr_len);
> + }
>
> return 0;
> }
>
> +static int enic_set_mac_address(struct net_device *netdev, void *p)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> /* netif_tx_lock held, BHs disabled */
> static void enic_set_multicast_list(struct net_device *netdev)
> {
Thsi looks funny. So you just ignore the address that gets passed to
enic_set_mac_addr for dynamic interfaces and instead set a random
address?
Arnd
next prev parent reply other threads:[~2010-05-06 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 4:42 [net-next-2.6 V5 PATCH 0/3] Add port-profile netlink support Scott Feldman
2010-05-06 4:42 ` [net-next-2.6 V5 PATCH 1/3] Add netdev/netlink port-profile support (was iovnl) Scott Feldman
2010-05-06 4:42 ` [net-next-2.6 V5 PATCH 2/3] Add ndo_{set|get}_vf_port_profile op support for enic dynamic vnics Scott Feldman
2010-05-06 13:47 ` Arnd Bergmann [this message]
2010-05-06 16:25 ` Scott Feldman
2010-05-06 16:45 ` Arnd Bergmann
2010-05-06 4:42 ` [net-next-2.6 V5 PATCH 3/3] Add SR-IOV support to enic (please don't apply this patch) Scott Feldman
2010-05-06 13:51 ` [net-next-2.6 V5 PATCH 0/3] Add port-profile netlink support Arnd Bergmann
2010-05-06 16:19 ` Scott Feldman
2010-05-06 16:42 ` Arnd Bergmann
2010-05-08 23:20 ` [PATCH] virtif: initial interface extensions Arnd Bergmann
2010-05-10 15:37 ` Stefan Berger
2010-05-10 18:56 ` Scott Feldman
2010-05-10 21:46 ` Arnd Bergmann
2010-05-10 23:51 ` Stefan Berger
2010-05-11 0:25 ` Scott Feldman
2010-05-11 12:59 ` Arnd Bergmann
2010-05-11 17:15 ` Vivek Kashyap
[not found] ` <OFFE8F5F70.5C07C656-ON8525771F.00787A71-8525771F.007FCDFC@us.ibm.com>
2010-05-11 12:25 ` Arnd Bergmann
[not found] ` <OF2E2B37D4.51A81D74-ON85257720.0045FA96-85257720.004C5403@us.ibm.com>
2010-05-11 14:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005061547.22400.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=chrisw@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scofeldm@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox