Subject: Re: [PATCH] X25: Replace BKL in sockopts calls

From: David Miller <[email-masked]>
Date: Mon, 10 May 2010 04:44:48 -0700 (PDT)

From: Eric Dumazet <[email-masked]>
Date: Mon, 10 May 2010 06:50:40 +0200

> Well, its probably better than lock_kernel() ;)
> 
> qbitincl is a char, I suspect some arches cant store a char in an atomic
> way ? Alpha comes to mind.

True.

> We now have lock_sock_bh()/unlock_sock_bh() for this kind of very short
> sections, where we cant sleep.

Another option is to simply use an atomic bitmask to represent these
booleans instead of a crufty set of chars.