From: David Miller <davem@davemloft•net>
To: arnd@arndb•de
Cc: chrisw@redhat•com, scofeldm@cisco•com, netdev@vger•kernel.org,
kaber@trash•net
Subject: Re: [net-next-2.6 V8 PATCH 1/2] Add netlink support for virtual port management
Date: Mon, 17 May 2010 17:47:45 -0700 (PDT) [thread overview]
Message-ID: <20100517.174745.02261900.davem@davemloft.net> (raw)
In-Reply-To: <201005151107.51522.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb•de>
Date: Sat, 15 May 2010 11:07:51 +0200
> On Saturday 15 May 2010 05:11:30 Chris Wright wrote:
>> * Scott Feldman (scofeldm@cisco•com) wrote:
>> > From: Scott Feldman <scofeldm@cisco•com>
>> >
>> > Add new netdev ops ndo_{set|get}_vf_port to allow setting of
>> > port-profile on a netdev interface. Extends netlink socket RTM_SETLINK/
>> > RTM_GETLINK with two new sub msgs called IFLA_VF_PORTS and IFLA_PORT_SELF
>> > (added to end of IFLA_cmd list). These are both nested atrtibutes
>> > using this layout:
>> >
>> > [IFLA_NUM_VF]
>> > [IFLA_VF_PORTS]
>> > [IFLA_VF_PORT]
>> > [IFLA_PORT_*], ...
>> > [IFLA_VF_PORT]
>> > [IFLA_PORT_*], ...
>> > ...
>> > [IFLA_PORT_SELF]
>> > [IFLA_PORT_*], ...
>> >
>> > These attributes are design to be set and get symmetrically. VF_PORTS
>> > is a list of VF_PORTs, one for each VF, when dealing with an SR-IOV
>> > device. PORT_SELF is for the PF of the SR-IOV device, in case it wants
>> > to also have a port-profile, or for the case where the VF==PF, like in
>> > enic patch 2/2 of this patch set.
>> >
>> > A port-profile is used to configure/enable the external switch virtual port
>> > backing the netdev interface, not to configure the host-facing side of the
>> > netdev. A port-profile is an identifier known to the switch. How port-
>> > profiles are installed on the switch or how available port-profiles are
>> > made know to the host is outside the scope of this patch.
>> >
>> > There are two types of port-profiles specs in the netlink msg. The first spec
>> > is for 802.1Qbg (pre-)standard, VDP protocol. The second spec is for devices
>> > that run a similar protocol as VDP but in firmware, thus hiding the protocol
>> > details. In either case, the specs have much in common and makes sense to
>> > define the netlink msg as the union of the two specs. For example, both specs
>> > have a notition of associating/deassociating a port-profile. And both specs
>> > require some information from the hypervisor manager, such as client port
>> > instance ID.
>> >
>> > The general flow is the port-profile is applied to a host netdev interface
>> > using RTM_SETLINK, the receiver of the RTM_SETLINK msg communicates with the
>> > switch, and the switch virtual port backing the host netdev interface is
>> > configured/enabled based on the settings defined by the port-profile. What
>> > those settings comprise, and how those settings are managed is again
>> > outside the scope of this patch, since this patch only deals with the
>> > first step in the flow.
>> >
>> > Signed-off-by: Scott Feldman <scofeldm@cisco•com>
>> > Signed-off-by: Roopa Prabhu<roprabhu@cisco•com>
>>
>> Assuming the SR-IOV VFINFO changes go in there will be some minor patch
>> conflicts to be sorted out.
>
> Right, I assume the best resolution then would be drop IFLA_VF_PORTS and
> put the IFLA_VF_PORT attribute inside IFLA_VF_INFO, correct?
>
>> Acked-by: Chris Wright <chrisw@redhat•com>
>
> Acked-by: Arnd Bergmann <arnd@arndb•de>
Hey guys, please respin these patches now that the SR-IOV VF patch is in
the tree.
Thanks!
next prev parent reply other threads:[~2010-05-18 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 1:04 [net-next-2.6 V8 PATCH 0/2] Add virtual port netlink support Scott Feldman
2010-05-15 1:04 ` [net-next-2.6 V8 PATCH 1/2] Add netlink support for virtual port management (was iovnl) Scott Feldman
2010-05-15 3:11 ` Chris Wright
2010-05-15 9:07 ` Arnd Bergmann
2010-05-18 0:47 ` David Miller [this message]
2010-05-15 1:04 ` [net-next-2.6 V8 PATCH 2/2] Add ndo_{set|get}_vf_port support for enic dynamic vnics Scott Feldman
2010-05-15 1:29 ` [net-next-2.6 V8 PATCH 0/2] Add virtual port netlink support Stephen Hemminger
2010-05-15 1:37 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517.174745.02261900.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=arnd@arndb$(echo .)de \
--cc=chrisw@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scofeldm@cisco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox