From: Wolfram Sang <w.sang@pengutronix•de>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: netdev@vger•kernel.org, Nicolas Pitre <nico@fluxnic•net>,
linux-arm-kernel@lists•infradead.org,
Herbert Valerio Riedel <hvr@gnu•org>
Subject: Re: [PATCH] phy/marvell: Add special settings for D-Link DNS-323 rev C1
Date: Mon, 17 May 2010 14:00:32 +0200 [thread overview]
Message-ID: <20100517120032.GI22781@pengutronix.de> (raw)
In-Reply-To: <1274096214.21352.735.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
> The problem is that the fixups are called -after- the config_init()
> callback of the PHY driver. However, the marvell m88e1118 PHY driver
> will unconditionally reset the LEDs setting.
Haven't checked, just an idea: Is it possible to change the init of the driver
to use Read-Modify-Write and thus keep your settings?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-05-17 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 0:27 [PATCH] phy/marvell: Add special settings for D-Link DNS-323 rev C1 Benjamin Herrenschmidt
2010-05-17 0:59 ` Wolfram Sang
2010-05-17 1:07 ` Benjamin Herrenschmidt
2010-05-17 11:36 ` Benjamin Herrenschmidt
2010-05-17 12:00 ` Wolfram Sang [this message]
2010-05-17 12:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517120032.GI22781@pengutronix.de \
--to=w.sang@pengutronix$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=hvr@gnu$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nico@fluxnic$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox