From: Denis Kirjanov <kirjanov@gmail•com>
To: Sonic Zhang <sonic.adi@gmail•com>
Cc: davem@davemloft•net, michael.hennerich@analog•com,
cooloney@kernel•org, uclinux-dist-devel@blackfin•uclinux.org,
netdev@vger•kernel.org
Subject: Re: [PATCH] bfin_mac: fix memleak in mii_bus{probe|remove}
Date: Tue, 18 May 2010 15:34:46 +0400 [thread overview]
Message-ID: <20100518113445.GA28386@coldcone> (raw)
In-Reply-To: <AANLkTikcB3f0KmkcnDsV46Xrpm3WcCLQklxbLSJfMTlW@mail.gmail.com>
On Tue, May 18, 2010 at 18:05 +0800, Sonic Zhang wrote:
> 2010/5/18 Denis Kirjanov <kirjanov@gmail•com <kirjanov@gmail•com>:
> > Fix memory leak with miibus->irq
> >
> > Signed-off-by: Denis Kirjanov <dkirjanov@kernel•org>
> > ---
> >
> > drivers/net/bfin_mac.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
> > index 39a54ba..7a17b8a 100644
> > --- a/drivers/net/bfin_mac.c
> > +++ b/drivers/net/bfin_mac.c
> > @@ -1627,6 +1627,7 @@ static int __devinit bfin_mii_bus_probe(struct platform_device *pdev)
> >
> > out_err_mdiobus_register:
> > mdiobus_free(miibus);
> > + kfree(miibus->irq);
>
> Should you move this kfree before mdiobus_free?
>
> > out_err_alloc:
> > peripheral_free_list(pin_req);
> >
> > @@ -1638,6 +1639,7 @@ static int __devexit bfin_mii_bus_remove(struct platform_device *pdev)
> > struct mii_bus *miibus = platform_get_drvdata(pdev);
> > platform_set_drvdata(pdev, NULL);
> > mdiobus_unregister(miibus);
> > + kfree(miibus->irq);
> > mdiobus_free(miibus);
> > peripheral_free_list(pin_req);
> > return 0;
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger•kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
Oops, yeah, fixed.
Thanks.
[PATCH] bfin_mac: fix memleak in mii_bus_{probe|remove}
Fix memory leak with miibus->irq
Signed-off-by: Denis Kirjanov <dkirjanov@kernel•org>
---
drivers/net/bfin_mac.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
index 39a54ba..368f333 100644
--- a/drivers/net/bfin_mac.c
+++ b/drivers/net/bfin_mac.c
@@ -1626,6 +1626,7 @@ static int __devinit bfin_mii_bus_probe(struct platform_device *pdev)
return 0;
out_err_mdiobus_register:
+ kfree(miibus->irq);
mdiobus_free(miibus);
out_err_alloc:
peripheral_free_list(pin_req);
@@ -1638,6 +1639,7 @@ static int __devexit bfin_mii_bus_remove(struct platform_device *pdev)
struct mii_bus *miibus = platform_get_drvdata(pdev);
platform_set_drvdata(pdev, NULL);
mdiobus_unregister(miibus);
+ kfree(miibus->irq);
mdiobus_free(miibus);
peripheral_free_list(pin_req);
return 0;
next prev parent reply other threads:[~2010-05-18 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 9:28 [PATCH] bfin_mac: fix memleak in mii_bus{probe|remove} Denis Kirjanov <kirjanov@gmail•com
2010-05-18 10:05 ` Sonic Zhang
2010-05-18 11:34 ` Denis Kirjanov [this message]
2010-05-18 21:13 ` David Miller
2010-05-18 21:15 ` David Miller
2010-05-19 5:18 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518113445.GA28386@coldcone \
--to=kirjanov@gmail$(echo .)com \
--cc=cooloney@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=michael.hennerich@analog$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sonic.adi@gmail$(echo .)com \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox