Subject: Re: [PATCH net-2.6] macvlan: do a proper cleanup in macvlan_common_newlink()

From: Jiri Pirko <[email-masked]>
Date: Mon, 24 May 2010 19:02:25 +0200

Mon, May 24, 2010 at 05:58:58PM CEST, [email-masked] wrote:
>Fixes possible memory leak.
>
>Signed-off-by: Jiri Pirko <[email-masked]>
>---
> drivers/net/macvlan.c |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
>index 4e238af..5f4694b 100644
>--- a/drivers/net/macvlan.c
>+++ b/drivers/net/macvlan.c
>@@ -634,11 +634,17 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
> 
> 	err = register_netdevice(dev);
> 	if (err < 0)
>-		return err;
>+		goto destroy_port;
> 
> 	list_add_tail(&vlan->list, &port->vlans);
> 	netif_stacked_transfer_operstate(lowerdev, dev);
>+
> 	return 0;
>+
>+destroy_port:
>+	macvlan_port_destroy(lowerdev);
>+
>+	return err;
> }
> EXPORT_SYMBOL_GPL(macvlan_common_newlink);
> 
>-- 
>1.6.6.1

Actually it should be rather like this:

Subject: [PATCH net-2.6] macvlan: do proper cleanup in macvlan_common_newlink() V2

Fixes possible memory leak.

Signed-off-by: Jiri Pirko <[email-masked]>
---
 drivers/net/macvlan.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 4e238af..87e8d4c 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -634,11 +634,18 @@ int macvlan_common_newlink(struct net *src_net, struct net_device *dev,
 
 	err = register_netdevice(dev);
 	if (err < 0)
-		return err;
+		goto destroy_port;
 
 	list_add_tail(&vlan->list, &port->vlans);
 	netif_stacked_transfer_operstate(lowerdev, dev);
+
 	return 0;
+
+destroy_port:
+	if (list_empty(&port->vlans))
+		macvlan_port_destroy(lowerdev);
+
+	return err;
 }
 EXPORT_SYMBOL_GPL(macvlan_common_newlink);
 
-- 
1.6.6.1