Subject: Re: boot crash in arp_error_report()

From: Ingo Molnar <[email-masked]>
Date: Fri, 28 May 2010 10:24:40 +0200

* Ingo Molnar <[email-masked]> wrote:

> 
> * David Miller <[email-masked]> wrote:
> 
> > From: Eric Dumazet <[email-masked]>
> > Date: Thu, 27 May 2010 22:18:24 +0200
> > 
> > > [PATCH] net: fix __neigh_event_send()
> > > 
> > > commit 7fee226ad23 (net: add a noref bit on skb dst) missed one spot
> > > where an skb is enqueued, with a possibly not refcounted dst entry.
> > > 
> > > __neigh_event_send() inserts skb into arp_queue, so we must make sure
> > > dst entry is refcounted, or dst entry can be freed by garbage collector
> > > after caller exits from rcu protected section.
> > > 
> > > Reported-by: Ingo Molnar <[email-masked]>
> > > Signed-off-by: Eric Dumazet <[email-masked]>
> > 
> > Applied, thanks Eric.
> > 
> > Ingo can we get a confirmation that this fixes the bootup crash?
> 
> Sure, will let you know how it goes.

Preliminary testing shows that Eric's patch solves the problem.

Tested-by: Ingo Molnar <[email-masked]>

Thanks!

	Ingo