Subject: Re: [PATCH] can: mpc5xxx_can.c: Fix build failure

From: Anatolij Gustschin <[email-masked]>
Date: Mon, 31 May 2010 20:54:23 +0200

Hi Wolfgang,

On Mon, 31 May 2010 20:27:01 +0200
Wolfgang Grandegger <[email-masked]> wrote:
...
> > @@ -251,7 +251,7 @@ static int __devinit mpc5xxx_can_probe(struct of_device *ofdev,
> >  				       const struct of_device_id *id)
> >  {
> >  	struct mpc5xxx_can_data *data = (struct mpc5xxx_can_data *)id->data;
> > -	struct device_node *np = ofdev->node;
> > +	struct device_node *np = ofdev->dev.of_node;
> >  	struct net_device *dev;
> >  	struct mscan_priv *priv;
> >  	void __iomem *base;
> 
> The patch seems incomplete. I get at least one more warning (because
> I'm compiling for 52xx, I guess):

Yes, this is true. Unfortunately I didn't compile for 5200 and the issue
didn't show up.

>   CC      drivers/net/can/mscan/mpc5xxx_can.o
> drivers/net/can/mscan/mpc5xxx_can.c: In function 'mpc52xx_can_get_clock':
> drivers/net/can/mscan/mpc5xxx_can.c:76: error: 'struct of_device' has no member named 'node'
> 
> Should I send v2? Thanks for fixing that. I also checked the
> sja1000_of_platform driver,  which was converted correctly.

I will send v2 patch shortly. Thanks for reporting!

Anatolij