Subject: Re: [PATCH net-next-2.6] net: replace hooks in __netif_receive_skb V5

From: Stephen Hemminger <[email-masked]>
Date: Wed, 2 Jun 2010 08:07:30 -0700

On Wed, 2 Jun 2010 09:52:08 +0200
Jiri Pirko <[email-masked]> wrote:

> +
> +	err = netdev_rx_handler_register(dev, macvlan_handle_frame);
> +	if (err) {
> +		rcu_assign_pointer(dev->macvlan_port, NULL);
> +		kfree(port);
> +	}
> +
> +	return err;
>  }

Rcu assign is not necessary here for because the hook didn't
get registered so there is no way for other CPU to see it.

--