From: Steffen Klassert <steffen.klassert@secunet•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH] net: check for refcount if pop a stacked dst_entry
Date: Fri, 4 Jun 2010 13:23:46 +0200 [thread overview]
Message-ID: <20100604112346.GC13408@secunet.com> (raw)
In-Reply-To: <1275648679.2482.43.camel@edumazet-laptop>
On Fri, Jun 04, 2010 at 12:51:19PM +0200, Eric Dumazet wrote:
>
> Hmm, this might fix the thing, but we probably can do it without the
> dst_clone(), if you replace the
>
> skb_dst_set(skb, dst);
>
> by
>
> skb_dst_set_noref(skb, dst);
>
> in xfrm_output_one() ?
>
Yes, this should work too. I'll update the patch to use
skb_dst_set_noref() in xfrm_output_one() and remove the
dst_clone() in skb_dst_pop().
next prev parent reply other threads:[~2010-06-04 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 10:40 xfrm: warning on negative dst refcount Steffen Klassert
2010-06-04 10:41 ` [PATCH] net: check for refcount if pop a stacked dst_entry Steffen Klassert
2010-06-04 10:51 ` Eric Dumazet
2010-06-04 11:23 ` Steffen Klassert [this message]
2010-06-04 11:57 ` [PATCH v2] " Steffen Klassert
2010-06-04 12:06 ` Eric Dumazet
2010-06-04 22:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100604112346.GC13408@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox