Subject: Re: [0/8] netpoll/bridge fixes

From: Stephen Hemminger <[email-masked]>
Date: Thu, 10 Jun 2010 07:49:12 -0700

On Thu, 10 Jun 2010 22:40:47 +1000
Herbert Xu <[email-masked]> wrote:

> Hi:
> 
> Qianfeng Zhang reported that he was seeing crashes with the
> attached backtrace.
> 
> I tracked this down to the recently added netpoll support in
> the bridge device.  It's a classic use-after-free problem.
> 
> Trying to solve it brought out a host of other issues, some of
> which existed prior to the new bridge code.  The following patches
> attempt to address some of these issues.
> 
> Warning, this is completely untested (apart from compiling with
> everything enabled) so please look but don't merge :)

Thanks for looking at this, and yes the original code does
look buggy. Not sure if I like the use of in_irq() to handle the netpoll
packets as special case. Is in_irq() really reliable for this?