Subject: Re: [patch] enic: cleanup vic_provinfo_alloc()

From: Dan Carpenter <[email-masked]>
Date: Thu, 10 Jun 2010 11:32:30 +0200

On Thu, Jun 10, 2010 at 11:22:49AM +0200, walter harms wrote:
> > +	vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags);
> > +	if (!vp)
> >  		return NULL;
> >  
> >  	memcpy(vp->oui, oui, sizeof(vp->oui));
> > --
> 
> 
> This looks like memdup() ?
> 

No.  VIC_PROVINFO_MAX_DATA is larger than sizeof(vp->oui).

regards,
dan carpenter

> re,
>  wh