From: "markus@trippelsdorf•de" <markus@trippelsdorf•de>
To: John Fastabend <john.r.fastabend@intel•com>
Cc: David Miller <davem@davemloft•net>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
yanmin_zhang@linux•intel.com, alex.shi@intel•com,
tim.c.chen@intel•com
Subject: Re: mpd client timeouts (bisected) 2.6.35-rc3
Date: Sun, 13 Jun 2010 22:59:22 +0200 [thread overview]
Message-ID: <20100613205922.GA1806@arch.tripp.de> (raw)
In-Reply-To: <4C15414E.5090201@intel.com>
On Sun, Jun 13, 2010 at 01:36:30PM -0700, John Fastabend wrote:
> John Fastabend wrote:
> >David Miller wrote:
> >>From: Markus Trippelsdorf <markus@trippelsdorf•de>
> >>Date: Sat, 12 Jun 2010 12:28:02 +0200
> >>
> >>>Commit 597a264b1a9c7e36d1728f677c66c5c1f7e3b837:
> >>>»net: deliver skbs on inactive slaves to exact matches«
> >>>
> >>>causes large timeouts when mpd clients try to connect to a locally
> >>>running mpd (music player demon) on my machine. This makes it
> >>>impossible to control mpd.
> >>>
> >>>I bisected this down to the commit mentioned above.
> >>>Reverting the commit from 2.6.35-rc3 also solves the problem.
> >>John, find an easy and fast way to fix this or else I am
> >>going to revert.
> >>
> >>Thanks.
> >
> >Looks like skbs are hitting loopback_xmit() with deliver_no_wcard
> >set. Then in the receive path these skbs are only delivered to
> >exact matches. Not sure why this bit is set here, I'll track this
> >down first thing tomorrow.
> >
> >Thanks,
> >John.
> >--
>
> Needed to set the wcard bit in copy_skb_header otherwise it will not
> be cleared when called from skb_clone. Which then hits the loopback
> device gets pushed into the rx path and is eventually dropped. The
> following patch fixes this. Hopefully, this is easy and fast enough
> for you Dave.
>
>
> [PATCH] net: fix deliver_no_wcard regression on loopback device
This solves the problem here. Thanks.
Tested-by: Markus Trippelsdorf <markus@trippelsdorf•de>
--
Markus
next prev parent reply other threads:[~2010-06-13 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 10:28 mpd client timeouts (bisected) 2.6.35-rc3 Markus Trippelsdorf
2010-06-12 21:58 ` David Miller
2010-06-13 8:05 ` John Fastabend
2010-06-13 20:36 ` John Fastabend
2010-06-13 20:50 ` Eric Dumazet
2010-06-14 0:14 ` David Miller
2010-06-13 20:59 ` markus [this message]
2010-06-14 0:14 ` David Miller
2010-06-16 10:01 ` Christian Kujau
2010-06-17 15:05 ` Christoph Fritz
2010-06-14 0:13 ` David Miller
2010-06-14 14:13 ` Michael S. Tsirkin
2010-06-17 5:16 ` Shi, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100613205922.GA1806@arch.tripp.de \
--to=markus@trippelsdorf$(echo .)de \
--cc=alex.shi@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tim.c.chen@intel$(echo .)com \
--cc=yanmin_zhang@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox