From: Stephen Hemminger <shemminger@vyatta•com>
To: Jiri Pirko <jpirko@redhat•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, kaber@trash•net,
eric.dumazet@gmail•com
Subject: Re: [PATCH net-next-2.6 3/3] bridge: use rx_handler_data pointer to store net_bridge_port pointer V2
Date: Tue, 15 Jun 2010 09:30:35 -0700 [thread overview]
Message-ID: <20100615093035.6f54c085@nehalam> (raw)
In-Reply-To: <20100615132833.GB3797@psychotron.lab.eng.brq.redhat.com>
On Tue, 15 Jun 2010 15:28:34 +0200
Jiri Pirko <jpirko@redhat•com> wrote:
> diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
> index 7805bbf..e7f4703 100644
> --- a/drivers/net/ksz884x.c
> +++ b/drivers/net/ksz884x.c
> @@ -5718,7 +5718,7 @@ static void dev_set_promiscuous(struct net_device *dev, struct dev_priv *priv,
> * from the bridge.
> */
> if ((hw->features & STP_SUPPORT) && !promiscuous &&
> - dev->br_port) {
> + dev->priv_flags & IFF_BRIDGE_PORT) {
I like this patch except for one thing. The mask here should be surrounded
by paren's to avoid the possible confusion about && and & in same if
statement. The C precedence rules allow this but humans get confused.
next prev parent reply other threads:[~2010-06-15 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 13:34 [PATCH net-next-2.6 0/3] net: use rx_handler_data pointer for bridge and macvlan ports Jiri Pirko
2010-06-10 13:34 ` [PATCH net-next-2.6 1/3] net: add rx_handler data pointer Jiri Pirko
2010-06-15 18:49 ` David Miller
2010-06-10 13:35 ` [PATCH net-next-2.6 2/3] macvlan: use rx_handler_data pointer to store macvlan_port pointer Jiri Pirko
2010-06-15 12:48 ` Patrick McHardy
2010-06-15 13:27 ` [PATCH net-next-2.6 2/3] macvlan: use rx_handler_data pointer to store macvlan_port pointer V2 Jiri Pirko
2010-06-15 18:50 ` David Miller
2010-06-10 13:36 ` [PATCH net-next-2.6 3/3] bridge: use rx_handler_data pointer to store net_bridge_port pointer Jiri Pirko
2010-06-15 13:28 ` [PATCH net-next-2.6 3/3] bridge: use rx_handler_data pointer to store net_bridge_port pointer V2 Jiri Pirko
2010-06-15 16:30 ` Stephen Hemminger [this message]
2010-06-15 16:51 ` Jiri Pirko
2010-06-15 16:50 ` [PATCH net-next-2.6 3/3 v3] bridge: use rx_handler_data pointer to store net_bridge_port pointer Jiri Pirko
2010-06-15 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615093035.6f54c085@nehalam \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox