Subject: Re: [PATCH net-next-2.6] macvtap: Return error when macvlan drops the packet

From: Arnd Bergmann <[email-masked]>
Date: Mon, 12 Jul 2010 12:44:04 +0200

On Monday 12 July 2010, Shirley Ma wrote:
> 
> Return err when macvlan dropps the packet.

Can you be more specific why you think this is the right idea?

As far as I can tell, this will return '1' to user space for a dropped
packet (NET_XMIT_DROP) or another positive return value.
While this might be nice for a user application to know, neither does
qemu check for this nor does it match the read(2) documentation.

I fear if we want congestion control to improve, we need to do it
differently.

	Arnd