Subject: Re: [PATCH] net: Add batman-adv meshing protocol

From: Sven Eckelmann <[email-masked]>
Date: Tue, 20 Jul 2010 21:21:32 +0200

Ben Hutchings wrote:
> On Tue, 2010-07-20 at 20:49 +0200, Sven Eckelmann wrote:
> > Abraham Arce wrote:
> > > Minor comments...
> > > 
> > > 1. Is it ok to have a README in drivers directory? why not moving it
> > > to Documentation/networking?
> > 
> > Thanks, I will check if Documentation/networking is a better place.
> > 
> > > 2. Compilation error, one extra arguments passed
> > > 
> > > - stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
> > > + stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
> > > 
> > >   LD      kernel/built-in.o
> > > 
> > > net/batman-adv/hard-interface.c: In function 'batman_skb_recv':
> > > net/batman-adv/hard-interface.c:482: error: too many arguments to
> > > function 'dev_get_stats'
> > > make[2]: *** [net/batman-adv/hard-interface.o] Error 1
> > > make[2]: *** Waiting for unfinished jobs....
> > > make[1]: *** [net/batman-adv] Error 2
> > > make: *** [net] Error 2
> > 
> > Do you use linux-next or net-next-2.6? Because this is needed to get it
> > compiled as dev_get_stats was changed some time ago (commit
> > 28172739f0a276eb8d6ca917b3974c2edb036da3), but this is not part of
> > 2.6.35.
> 
> Even so, that cast is a bug following commit
> 3cfde79c6c7c8002375c4a8e5be7f602fbb9675d.

I've only noticed the changes to the batman-adv code in staging through 
28172739f0a276eb8d6ca917b3974c2edb036da3, but missed that more is needed with 
the above mentioned one. Thanks a lot for the hint.

Best regards,
	Sven