From: Stephen Hemminger <shemminger@vyatta•com>
To: Ulrich Weber <uweber@astaro•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare
Date: Fri, 23 Jul 2010 09:01:39 -0700 [thread overview]
Message-ID: <20100723090139.346b6cca@nehalam> (raw)
In-Reply-To: <20100723133910.GC12942@babylon>
On Fri, 23 Jul 2010 15:39:10 +0200
Ulrich Weber <uweber@astaro•com> wrote:
> otherwise "if ((int)val == -1)" will never match on 64 bit systems
>
> Signed-off-by: Ulrich Weber <uweber@astaro•com>
> ---
> ip/iproute.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 04b253a..711576e 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -494,7 +494,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
> val = *(unsigned*)RTA_DATA(mxrta[i]);
> switch (i) {
> case RTAX_HOPLIMIT:
> - if ((long)val == -1)
> + if ((int)val == -1)
> val = 0;
> /* fall through */
> default:
All applied
--
next prev parent reply other threads:[~2010-07-23 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 13:39 [PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare Ulrich Weber
2010-07-23 16:01 ` Stephen Hemminger [this message]
2010-07-23 19:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723090139.346b6cca@nehalam \
--to=shemminger@vyatta$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=uweber@astaro$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox