From: Arnd Bergmann <arnd@arndb•de>
To: Krishna Kumar2 <krkumar2@in•ibm.com>
Cc: Changli Gao <xiaosuo@gmail•com>,
bhutchings@solarflare•com, davem@davemloft•net, mst@redhat•com,
netdev@vger•kernel.org, therbert@google•com
Subject: Re: [PATCH v4 2/2] macvtap: Implement multiqueue for macvtap driver
Date: Wed, 4 Aug 2010 16:54:45 +0200 [thread overview]
Message-ID: <201008041654.45982.arnd@arndb.de> (raw)
In-Reply-To: <OF3D82198C.4738EB40-ON65257775.0046DC1D-65257775.004997E7@in.ibm.com>
On Wednesday 04 August 2010, Krishna Kumar2 wrote:
> 1. Use % to find the slot.
> 2. If slot is null - I don't want to handle this since I think
> it is better to return NULL if some fd's were closed by user.
> Typically this should never happen since fd's are opened and
> passed to vhost for setting up the backend. So if they are
> closed, then I think NULL is OK.
>
Having some of the file descriptors closed is not something that
we should optimize for, but then again it makes sense to still
keep going, mostly for consistency reasons: One day we may
have a use case for a dynamically growing and shrinking set of
queues. Falling back to the first queue is probably ok, we can
always add optimizations when this becomes a real use case.
Arnd
next prev parent reply other threads:[~2010-08-04 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 10:55 [PATCH v4 1/2] core: Factor out flow calculation from get_rps_cpu Krishna Kumar
2010-08-04 10:55 ` [PATCH v4 2/2] macvtap: Implement multiqueue for macvtap driver Krishna Kumar
2010-08-04 11:37 ` Changli Gao
2010-08-04 13:25 ` Krishna Kumar2
2010-08-04 13:42 ` Changli Gao
2010-08-04 14:54 ` Arnd Bergmann [this message]
2010-08-04 11:22 ` [PATCH v4 1/2] core: Factor out flow calculation from get_rps_cpu Changli Gao
2010-08-04 12:02 ` Krishna Kumar2
2010-08-04 13:38 ` Changli Gao
2010-08-04 14:23 ` Krishna Kumar2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008041654.45982.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=krkumar2@in$(echo .)ibm.com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=therbert@google$(echo .)com \
--cc=xiaosuo@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox