Subject: Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation

From: "Luis R. Rodriguez" <[email-masked]>
Date: Thu, 5 Aug 2010 13:47:56 -0700

On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <[email-masked]>
> 
> Outdent the code following the if.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
> 
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
> 
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
> 
> if (p1[0].column == p2[0].column):
>   cocci.print_main("branch",p1)
>   cocci.print_secs("after",p2)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <[email-masked]>

Acked-by: Luis R. Rodriguez <[email-masked]>

> ---
> This patch doesn't change the semantics of the code.  But it might not be
> what is intended.

Your patch is correct, it wast a tab goof, thanks for fixing this.

  Luis