Subject: Re: [PATCH] Add firmware label support to iproute2

From: Stephen Hemminger <[email-masked]>
Date: Thu, 12 Aug 2010 14:12:40 -0400

On Thu, 12 Aug 2010 12:35:37 -0500
Narendra K <[email-masked]> wrote:

> +#ifndef LIBNETDEVNAME_PRESENT
>  			filter_dev = *argv;
> +#else
> +			if (netdev_alias_to_kernelname(*argv, kernel_name) < 0)
> +				show_firmware_alias_usage(*argv);
> +			filter_dev = kernel_name;
> +#endif
>  		}

like the kernel, I don't like ifdef cases in main code.
You should put in stub inline that returns appropriate error.

What happens if alias matches existing interface name?