From: Jarek Poplawski <jarkao2@gmail•com>
To: Plamen Petrov <pvp-lsts@fs•uni-ruse.bg>
Cc: Eric Dumazet <eric.dumazet@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>,
netdev@vger•kernel.org, bugzilla-daemon@bugzilla•kernel.org,
bugme-daemon@bugzilla•kernel.org
Subject: Re: [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev
Date: Mon, 23 Aug 2010 12:47:36 +0000 [thread overview]
Message-ID: <20100823124736.GA16966@ff.dom.local> (raw)
In-Reply-To: <4C725FCB.2000304@fs.uni-ruse.bg>
On Mon, Aug 23, 2010 at 02:47:23PM +0300, Plamen Petrov wrote:
> ???? 21.8.2010 ??. 11:07, Jarek Poplawski ????????????:
>> On Sat, Aug 21, 2010 at 09:50:58AM +0200, Eric Dumazet wrote:
>>> Le samedi 21 ao??t 2010 ?? 09:47 +0200, Jarek Poplawski a écrit :
>>>> On Fri, Aug 20, 2010 at 09:38:35PM +0200, Jarek Poplawski wrote:
>>>>> Plamen Petrov wrote, On 20.08.2010 12:53:
>>>>>> So, I guess its David and Herbert's turn?...
>>>>>
>>>>> If you're bored in the meantime I'd suggest to do check the realtek
>>>>> driver eg:
>>>>> - for locking with the patch below,
>>>>> - to turn off with ethtool its tx-checksumming and/or scatter-gather,
...
> Yeah, 3 days and counting, right until I decided to try the freshly
> announced 2.6.36-rc2.
>
> So I upgraded the kernel, but left the scripts that turn GRO off for
> the tg3 card still run at system startup. This way the system ran for
> 2 and a half hours, when I decided its time to try turning GRO on.
>
> I first tried to turn GRO on for the tg3 nic, and the system oopsed
> immediately (if the panic screen is necessary - please, ask for it).
>
> After the system came back, I tried turning GRO on for the 2 RealTek
> 8139 nics, too, but ethtool only accepted turning GRO off.
>
> And unfortunately, I can't test if other nics will fail the same way
> as the motherboard integrated tg3 I have does, so for now, this is
> only a tg3 + GRO on problem; I don't have any other hardware to test
> with available.
A little misunderstanding: I was intersted with turning off some
features on realteks to change the packet path from tg3 with gro
to realtek without gro and without tx-checksumming etc.
But maybe you could try the patch below instead (so the patched
kernel, tg3 with gro on, and realteks without any change).
Thanks,
Jarek P.
--- (for debugging only)
diff --git a/net/core/dev.c b/net/core/dev.c
index 3721fbb..51823cd 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1935,6 +1935,23 @@ static inline int skb_needs_linearize(struct sk_buff *skb,
illegal_highdma(dev, skb))));
}
+static int skb_csum_start_bug(struct sk_buff *skb)
+{
+
+ if (skb->ip_summed == CHECKSUM_PARTIAL) {
+ long csstart;
+
+ csstart = skb->csum_start - skb_headroom(skb);
+ if (WARN_ON(csstart > skb_headlen(skb))) {
+ pr_warning("csum_start %d, headroom %d, headlen %d\n",
+ skb->csum_start, skb_headroom(skb),
+ skb_headlen(skb));
+ return 1;
+ }
+ }
+ return 0;
+}
+
int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
struct netdev_queue *txq)
{
@@ -1955,11 +1972,13 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
skb_orphan_try(skb);
if (netif_needs_gso(dev, skb)) {
+ skb_csum_start_bug(skb);
if (unlikely(dev_gso_segment(skb)))
goto out_kfree_skb;
if (skb->next)
goto gso;
} else {
+ skb_csum_start_bug(skb);
if (skb_needs_linearize(skb, dev) &&
__skb_linearize(skb))
goto out_kfree_skb;
@@ -1997,7 +2016,12 @@ gso:
if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
skb_dst_drop(nskb);
- rc = ops->ndo_start_xmit(nskb, dev);
+ if (skb_csum_start_bug(skb)) {
+ kfree_skb(skb);
+ rc = NETDEV_TX_OK;
+ } else
+ rc = ops->ndo_start_xmit(nskb, dev);
+
if (unlikely(rc != NETDEV_TX_OK)) {
if (rc & ~NETDEV_TX_MASK)
goto out_kfree_gso_skb;
next prev parent reply other threads:[~2010-08-23 12:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-16626-10286@https.bugzilla.kernel.org/>
2010-08-19 22:21 ` [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev Andrew Morton
2010-08-20 5:03 ` Plamen Petrov
2010-08-20 5:11 ` Andrew Morton
2010-08-20 6:12 ` Plamen Petrov
2010-08-20 6:20 ` Andrew Morton
2010-08-20 6:26 ` Plamen Petrov
2010-08-20 6:34 ` Eric Dumazet
2010-08-20 6:57 ` Plamen Petrov
2010-08-20 7:38 ` Plamen Petrov
2010-08-20 8:31 ` Plamen Petrov
2010-08-20 9:19 ` Plamen Petrov
2010-08-20 10:26 ` Eric Dumazet
2010-08-20 10:53 ` Plamen Petrov
2010-08-20 19:38 ` Jarek Poplawski
2010-08-21 7:47 ` Jarek Poplawski
2010-08-21 7:50 ` Eric Dumazet
2010-08-21 8:07 ` Jarek Poplawski
2010-08-23 11:47 ` Plamen Petrov
2010-08-23 12:35 ` Eric Dumazet
2010-08-23 12:47 ` Jarek Poplawski [this message]
2010-08-23 13:00 ` Eric Dumazet
2010-08-23 13:10 ` Jarek Poplawski
2010-08-23 13:43 ` Plamen Petrov
2010-08-23 14:05 ` Plamen Petrov
2010-08-23 14:14 ` Jarek Poplawski
2010-08-24 4:51 ` Plamen Petrov
2010-08-24 5:01 ` Eric Dumazet
2010-08-24 8:43 ` Plamen Petrov
2010-08-24 13:27 ` Plamen Petrov
2010-08-24 15:08 ` Eric Dumazet
2010-08-24 17:25 ` Plamen Petrov
2010-08-24 18:22 ` Jarek Poplawski
2010-08-24 19:19 ` Eric Dumazet
2010-08-25 7:05 ` Plamen Petrov
2010-08-29 7:48 ` [PATCH] net: reset ip_summed in skb_tunnel_rx() Eric Dumazet
2010-08-29 15:35 ` Jesse Gross
2010-08-27 8:44 ` [Bugme-new] [Bug 16626] New: Machine hangs with EIP at skb_copy_and_csum_dev Plamen Petrov
2010-08-24 5:19 ` Plamen Petrov
2010-08-24 6:18 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823124736.GA16966@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=bugzilla-daemon@bugzilla$(echo .)kernel.org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pvp-lsts@fs$(echo .)uni-ruse.bg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox